Skip to content

Fix: Improve AutocompleteInput creation support #10391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
slax57 merged 5 commits into from
Dec 3, 2024
Merged

Fix: Improve AutocompleteInput creation support #10391

slax57 merged 5 commits into from
Dec 3, 2024

Conversation

@djhi
Copy link
Collaborator

@djhi djhi commented Dec 3, 2024 •
edited
Loading

Problem

Fixes #10274

When entering a unknown value in an <AutocompleteInput> or <AutocompleteArrayInput> that supports creation, users have to click on the creation menu item. This is cumbersome as MUI <AutoComplete> supports creating items by pressing Enter

Solution

Properly handle the case in our onChange handler.

How To Test

Check any of the stories that supports creation, enter a new item and validate it with Enter. For instance:

Additional Checks

  • The PR targets master for a bugfix, or next for a feature
  • The PR includes unit tests (if not possible, describe why)
  • The PR includes one or several stories (if not possible, describe why)
  • The documentation is up to date

Also, please make sure to read the contributing guidelines.

@djhi djhi added the WIP Work In Progress label Dec 3, 2024
@djhi djhi changed the title Improve AutocompleteInput creation support Fix: Improve AutocompleteInput creation support Dec 3, 2024
@djhi djhi added RFR Ready For Review and removed WIP Work In Progress labels Dec 3, 2024
@slax57 slax57 self-requested a review December 3, 2024 13:46
slax57
slax57 reviewed Dec 3, 2024
View reviewed changes
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, but the solution is very elegant! Nice!

@slax57 slax57 added this to the 5.4.2 milestone Dec 3, 2024
@slax57 slax57 merged commit 8c814a4 into master Dec 3, 2024
13 checks passed
@slax57 slax57 deleted the improve-array-input-create-support branch December 3, 2024 16:46
@djhi djhi mentioned this pull request Jan 21, 2025
Closed
@slax57 slax57 mentioned this pull request May 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slax57 slax57 slax57 approved these changes

Assignees

No one assigned

Labels

RFR Ready For Review

Milestone

5.4.2

Development

Successfully merging this pull request may close these issues.

<AutocompleteArrayInput onCreate /> undefined value en enter

3 participants

@djhi @slax57